Skip to content

Conversation

sunlijun-610
Copy link
Contributor

Change pcaddu12i to pcalau12i in relocation IMAGE_REL_LOONGARCH64_PC.
Fix GT_CNS_INT generation in CodeGen::genCodeForJumpCompare.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jun 13, 2024
Copy link
Contributor

@shushanhf shushanhf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @jakobbotsch @MichalStrehovsky

This PR is the first patch before pushing the Native-AOT for LoongArch64, which followed the llvm's relocation.

LGTM
Thanks

Copy link
Member

@MichalStrehovsky MichalStrehovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes under tools look good to me!

@shushanhf
Copy link
Contributor

Hi, @jakobbotsch
Could you please review this PR?
Thanks!

@shushanhf
Copy link
Contributor

Hi, @jakobbotsch Could you please review this PR? Thanks!

Hi, @jakobbotsch
Could you please review this PR?

@jakobbotsch jakobbotsch merged commit 416cfd3 into dotnet:main Jun 24, 2024
@am11
Copy link
Member

am11 commented Jun 24, 2024

This PR is the first patch before pushing the Native-AOT for LoongArch64, which followed the llvm's relocation.

both @filipnavara and I are looking forward to it. 😉

@shushanhf
Copy link
Contributor

This PR is the first patch before pushing the Native-AOT for LoongArch64, which followed the llvm's relocation.

both @filipnavara and I are looking forward to it. 😉

we will push the second PR later.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-loongarch64 area-crossgen2-coreclr community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants