Fix x86 Windows legs #103411
Merged
Fix x86 Windows legs #103411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think we had a bad interaction between #103332 and #103273. Windows x86 with native AOT got broken in Preview 5 (#86573 (comment)).
ghost
added
the
needs-area-label
Closed
EgorBo
approved these changes
Jun 13, 2024
MichalStrehovsky
added a commit
to MichalStrehovsky/runtime
that referenced
this pull request
Jun 14, 2024
This reverts commit 6927fea.
MichalStrehovsky
added a commit
that referenced
this pull request
Jun 15, 2024
* Revert "Do not set UseNativeAotForComponents for arm32 MUSL (#103469)" This reverts commit f1f0750. * Revert "Set UseNativeAotForComponents to false on bionic (#103454)" This reverts commit d901213. * Revert "Try fixing x86 Windows legs (#103411)" This reverts commit 6927fea. * Revert "Consolidate <NativeAotSupported definitions (#103273)" This reverts commit b86c463.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we had a bad interaction between #103332 and #103273.
Windows x86 with native AOT got broken in Preview 5 (#86573 (comment)) and I failed to realize we're unblocking it.