Skip to content

[wasm] Move hardcoded _BoolPropertiesThatTriggerRelinking to wasm-props.json included in the runtime pack #103422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 18, 2024
Merged

[wasm] Move hardcoded _BoolPropertiesThatTriggerRelinking to wasm-props.json included in the runtime pack #103422

merged 5 commits into from
Jun 18, 2024

Conversation

ilonatommy
Copy link
Member

@ilonatommy ilonatommy commented Jun 13, 2024 •
edited
Loading

Fixes #91628.

Wasi wbt had an error of not setting WasmBuildNative=true in NativeBuildOrPublishFails - this PR fixes it.

@ilonatommy ilonatommy added arch-wasm WebAssembly architecture area-Build-mono labels Jun 13, 2024
@ilonatommy ilonatommy self-assigned this Jun 13, 2024
@ilonatommy
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jun 13, 2024
Closed
Closed
Closed
Closed
maraf
maraf reviewed Jun 14, 2024
View reviewed changes
@build-analysis build-analysis bot mentioned this pull request Jun 14, 2024
Open
This was referenced Jun 17, 2024
Open
Closed
@ilonatommy
Copy link
Member Author

ilonatommy commented Jun 18, 2024 •
edited
Loading

Failures are #46020
update:
the message is the same as in the quoted issue but it can be connected with the removal of Condition="'$(_IsToolchainMissing)' != 'true'" and problems with finding ReadWasmProps task.

@ilonatommy ilonatommy added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Jun 18, 2024
@ilonatommy ilonatommy removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Jun 18, 2024
@build-analysis build-analysis bot mentioned this pull request Jun 18, 2024
Open
3 tasks
@ilonatommy
Copy link
Member Author

/ba-g infrastructure issues - timeouts on non-related lanes

@ilonatommy ilonatommy merged commit 93eacbd into dotnet:main Jun 18, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maraf maraf maraf approved these changes

@akoeplinger akoeplinger Awaiting requested review from akoeplinger akoeplinger is a code owner

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@pavelsavara pavelsavara Awaiting requested review from pavelsavara pavelsavara is a code owner

Assignees

@ilonatommy ilonatommy

Labels
arch-wasm WebAssembly architecture area-Build-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[wasm] Move the default property settings that were used to build the runtime pack, to wasm-props.json included in the runtime pack
2 participants
@ilonatommy @maraf