Skip to content

Fix the flakiness of new BinaryFormatter tests #103476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 17, 2024
Merged

Fix the flakiness of new BinaryFormatter tests #103476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
56478b1
reproduce the problem by calling EqualityExtensions.CheckEquals up-fr…
adamsitnik Jun 14, 2024
63cb914
change the test class Equals method implementation and allow the bran…
adamsitnik Jun 14, 2024
4f7b3d3
change the affected blob to represent all fields, including lazy-eval…
adamsitnik Jun 14, 2024
a205d9d
do not cache the test input data, as some tests may by accident mutat…
adamsitnik Jun 14, 2024
d3f1217
remove the check I've added recently but was not present in the origi…
adamsitnik Jun 14, 2024
853fa6b
add a call to EqualityExtensions.CheckEquals for all the tests that u…
adamsitnik Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/libraries/System.Resources.Extensions/tests/BinaryFormatTests/Common/BasicObjectTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ public abstract class BasicObjectTests<T> : SerializationTest<T> where T : ISeri
[MemberData(nameof(SerializableObjects))]
public void DeserializeStoredObjects(object value, TypeSerializableValue[] serializedData)
{
_ = value;
// Following call may change the contents of the fields by invoking lazy-evaluated properties.
EqualityExtensions.CheckEquals(value, value);

int platformIndex = serializedData.GetPlatformIndex();
for (int i = 0; i < serializedData.Length; i++)
Expand Down Expand Up @@ -48,6 +49,9 @@ public void BasicObjectsRoundtrip(
FormatterAssemblyStyle assemblyMatching,
FormatterTypeStyle typeStyle)
{
// Following call may change the contents of the fields by invoking lazy-evaluated properties.
EqualityExtensions.CheckEquals(value, value);

object deserialized = RoundTrip(value, typeStyle: typeStyle, assemblyMatching: assemblyMatching);

// string.Empty and DBNull are both singletons
Expand Down
Loading