Skip to content

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Jun 18, 2024

  • lockfileVersion: 3
  • upgrade packages
  • deleted samples which we don't maintain
  • fixed loading of NPM dependencies on NodeJS test

Fixes dotnet/source-build#4471

- upgrade packages
@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm labels Jun 18, 2024
@pavelsavara pavelsavara added this to the 9.0.0 milestone Jun 18, 2024
@pavelsavara pavelsavara self-assigned this Jun 18, 2024
Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

@pavelsavara
Copy link
Member Author

instead of #103599

@pavelsavara pavelsavara requested review from radekdoulik and maraf June 18, 2024 13:37
@pavelsavara pavelsavara marked this pull request as ready for review June 18, 2024 13:59
@pavelsavara pavelsavara requested a review from lewing as a code owner June 18, 2024 13:59
@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Copy link
Member Author

node is failing https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-103639-merge-223c23d758ac4bd1a6/WasmTestOnNodeJS-ST-System.Net.Http.Functional.Tests/1/console.20cb6deb.log?helixlogtype=result

[13:08:03] info: MONO_WASM: onConfigLoaded() failed Error [ERR_REQUIRE_ESM]: require() of ES Module C:\helix\work\workitem\e\node_modules\node-fetch\src\index.js from C:\helix\work\workitem\e\_framework\dotnet.js not supported.
[13:08:03] info: Instead change the require of index.js in C:\helix\work\workitem\e\_framework\dotnet.js to a dynamic import() which is available in all CommonJS modules.
[13:08:03] info: MONO_WASM: Failed to load config file ./blazor.boot.json Error [ERR_REQUIRE_ESM]: require() of ES Module C:\helix\work\workitem\e\node_modules\node-fetch\src\index.js from C:\helix\work\workitem\e\_framework\dotnet.js not supported.
[13:08:03] info: Instead change the require of index.js in C:\helix\work\workitem\e\_framework\dotnet.js to a dynamic import() which is available in all CommonJS modules. Error [ERR_REQUIRE_ESM]: require() of ES Module C:\helix\work\workitem\e\node_modules\node-fetch\src\index.js from C:\helix\work\workitem\e\_framework\dotnet.js not supported.
[13:08:03] info: Instead change the require of index.js in C:\helix\work\workitem\e\_framework\dotnet.js to a dynamic import() which is available in all CommonJS modules.
[13:08:03] info:     at file:///C:/helix/work/workitem/e/test-main.js:203:28
[13:08:03] info:     at Array.forEach (<anonymous>)
[13:08:03] info:     at loadNodeModules (file:///C:/helix/work/workitem/e/test-main.js:199:30)
[13:08:03] info:     at Object.onConfigLoaded (file:///C:/helix/work/workitem/e/test-main.js:278:21)
[13:08:03] info:     at Le (file:///C:/helix/work/workitem/e/_framework/dotnet.js:3:23901)
[13:08:03] info:     at async file:///C:/helix/work/workitem/e/_framework/dotnet.js:3:33390
[13:08:03] info:     at async file:///C:/helix/work/workitem/e/_framework/dotnet.js:3:39345
[13:08:03] info:     at async Object.create (file:///C:/helix/work/workitem/e/_framework/dotnet.js:3:39315)
[13:08:03] info:     at async run (file:///C:/helix/work/workitem/e/test-main.js:322:23)
[13:08:03] info:     at async file:///C:/helix/work/workitem/e/test-main.js:383:1

@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@steveisok
Copy link
Member

@pavelsavara the ws bump in the WebSockets test also needs applied in release/8.0

@pavelsavara
Copy link
Member Author

@pavelsavara the ws bump in the WebSockets test also needs applied in release/8.0

#104249

@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Component Governance detected 1 security related alerts at or above "High" severity
4 participants