Skip to content

Avoid a couple string allocs in EventSource's ManifestBuilder ctor #103744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 21, 2024
Merged

Avoid a couple string allocs in EventSource's ManifestBuilder ctor #103744

merged 1 commit into from
Jun 21, 2024

Conversation

stephentoub
Copy link
Member

No description provided.

@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti
See info in area-owners.md if you want to be subscribed.

@build-analysis build-analysis bot mentioned this pull request Jun 20, 2024
Closed
tarekgh
tarekgh approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@tarekgh tarekgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CC @davmason

This was referenced Jun 21, 2024
Closed
Closed
@stephentoub
Copy link
Member Author

/ba-g failures are known

@stephentoub stephentoub merged commit 3a8992a into dotnet:main Jun 21, 2024
@stephentoub stephentoub deleted the manifestsubstring branch June 21, 2024 13:58
rzikm pushed a commit to rzikm/dotnet-runtime that referenced this pull request Jun 24, 2024
@stephentoub @rzikm
Avoid a couple string allocs in EventSource's ManifestBuilder ctor (d…
b3258a8 
…otnet#103744)
@github-actions github-actions bot locked and limited conversation to collaborators Jul 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tarekgh tarekgh tarekgh approved these changes

+1 more reviewer

@davmason davmason davmason approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@stephentoub stephentoub

Labels
area-System.Diagnostics.Tracing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephentoub @tarekgh @davmason