Clean up JSON property lookup logic and add alternate key lookup support. #103836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis |
eiriktsarpalis
commented
Jun 21, 2024
...tem/Text/Json/Serialization/Converters/Object/ObjectWithParameterizedConstructorConverter.cs
Show resolved
Hide resolved
eiriktsarpalis
commented
Jun 21, 2024
...libraries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/JsonTypeInfo.Cache.cs
Show resolved
Hide resolved
eiriktsarpalis
commented
Jun 21, 2024
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/JsonTypeInfo.cs
Show resolved
Hide resolved
eiriktsarpalis
commented
Jun 22, 2024
...libraries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/JsonTypeInfo.Cache.cs
Show resolved
Hide resolved
This was referenced Jun 23, 2024
eiriktsarpalis
commented
Jul 1, 2024
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/PropertyRef.cs
Show resolved
Hide resolved
eiriktsarpalis
force-pushed
the
json-alternate-dict
branch
from
3ae7ec6 to
ceee5aa
Compare
stephentoub
reviewed
Jul 1, 2024
stephentoub
reviewed
Jul 1, 2024
...libraries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/JsonTypeInfo.Cache.cs
Show resolved
Hide resolved
stephentoub
reviewed
Jul 1, 2024
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/JsonTypeInfo.cs
Show resolved
Hide resolved
stephentoub
reviewed
Jul 1, 2024
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/PropertyRef.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jul 1, 2024
...ries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/PropertyRefCacheBuilder.cs
Show resolved
Hide resolved
|
@stephentoub would it be possible to take another look? Thanks. |
stephentoub
reviewed
Jul 8, 2024
stephentoub
reviewed
Jul 8, 2024
...libraries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/JsonTypeInfo.Cache.cs
Show resolved
Hide resolved
stephentoub
reviewed
Jul 8, 2024
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/JsonTypeInfo.cs
Show resolved
Hide resolved
stephentoub
reviewed
Jul 8, 2024
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/PropertyRef.cs
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
Jul 8, 2024
eiriktsarpalis
force-pushed
the
json-alternate-dict
branch
from
7e92d09 to
3ac2ee7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
I ran the benchmark suite and it appears that the change doesn't move the needle much performance-wise. The reason for that is that STJ uses an intermediate bespoke cache that does the heavy lifting when it comes to handling microbenchmark-like workloads.