Skip to content

Fix crash in DAC enum memory code that brings down createdump #104939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Fix crash in DAC enum memory code that brings down createdump #104939

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dae6b02
Fix crash in createdump in DAC enum memory code
Jul 16, 2024
291f011
Code review feedback
Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions src/coreclr/vm/excep.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7953,14 +7953,17 @@ BOOL ExceptionTypeOverridesStackTraceGetter(PTR_MethodTable pMT)
// find the slot corresponding to get_StackTrace
for (DWORD slot = g_pObjectClass->GetNumVirtuals(); slot < g_pExceptionClass->GetNumVirtuals(); slot++)
{
MethodDesc *pMD = g_pExceptionClass->GetMethodDescForSlot(slot);
LPCUTF8 name = pMD->GetName();

if (name != NULL && strcmp(name, "get_StackTrace") == 0)
MethodDesc *pMD = g_pExceptionClass->GetMethodDescForSlot_NoThrow(slot);
if (pMD != nullptr)
{
// see if the slot is overridden by pMT
MethodDesc *pDerivedMD = pMT->GetMethodDescForSlot(slot);
return (pDerivedMD != pMD);
LPCUTF8 name = pMD->GetName();

if (name != NULL && strcmp(name, "get_StackTrace") == 0)
{
// see if the slot is overridden by pMT
MethodDesc *pDerivedMD = pMT->GetMethodDescForSlot_NoThrow(slot);
return (pDerivedMD != pMD);
}
}
}

Expand Down