Skip to content

Guid(Int32, Int16, Int16, Byte[]) changes #105208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 22, 2024
Merged

Guid(Int32, Int16, Int16, Byte[]) changes #105208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5eec5ac
wip!
xtqqczze Jul 19, 2024
1f8b8ec
Copy byte array as block in `Guid` ctor
xtqqczze Jul 21, 2024
d9bf846
Revert "Copy byte array as block in `Guid` ctor"
xtqqczze Jul 22, 2024
9ac2d80
Avoid `Guid(Int32, Int16, Int16, Byte[])` ctor
xtqqczze Jul 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../System.ComponentModel.TypeConverter/src/System/ComponentModel/Design/StandardCommands.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1346,7 +1346,7 @@ private static class ShellGuids
internal static readonly Guid guidDsdCmdId = new Guid("{1F0FD094-8e53-11d2-8f9c-0060089fc486}");
internal static readonly Guid SID_SOleComponentUIManager = new Guid("{5efc7974-14bc-11cf-9b2b-00aa00573819}");
internal static readonly Guid GUID_VSTASKCATEGORY_DATADESIGNER = new Guid("{6B32EAED-13BB-11d3-A64F-00C04F683820}");
internal static readonly Guid GUID_PropertyBrowserToolWindow = new Guid(unchecked((int)0xeefa5220), unchecked((short)0xe298), unchecked((short)0x11d0), new byte[] { 0x8f, 0x78, 0x0, 0xa0, 0xc9, 0x11, 0x0, 0x57 });
internal static readonly Guid GUID_PropertyBrowserToolWindow = new Guid(0xeefa5220, 0xe298, 0x11d0, 0x8f, 0x78, 0x0, 0xa0, 0xc9, 0x11, 0x0, 0x57);
}
}
}
2 changes: 1 addition & 1 deletion src/libraries/System.Private.CoreLib/src/System/Guid.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,14 +130,14 @@ public Guid(int a, short b, short c, byte[] d)
_a = a;
_b = b;
_c = c;
_k = d[7]; // hoist bounds checks
_d = d[0];
_e = d[1];
_f = d[2];
_g = d[3];
_h = d[4];
_i = d[5];
_j = d[6];
_k = d[7];
}

// Creates a new GUID initialized to the value represented by the
Expand Down