Skip to content

Add alternate system color experimental feature #105525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 29, 2024
Merged

Add alternate system color experimental feature #105525

merged 2 commits into from
Jul 29, 2024

Conversation

JeremyKuhne
Copy link
Member

Allows overriding KnownColor system values with an alternate set, which in the initial iteration is "dark mode" colors. Enables "dark mode" features in Windows Forms.

This is from the approved part of dotnet/winforms#7641 with further naming iteration done offline with API review.

@KlausLoeffelmann pulled together the color set.

fyi: @ericstj

@JeremyKuhne JeremyKuhne requested a review from jeffhandley as a code owner July 26, 2024 00:04
@ghost
Copy link

ghost commented Jul 26, 2024

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Jul 26, 2024

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-drawing
See info in area-owners.md if you want to be subscribed.

@JeremyKuhne
Copy link
Member Author

High contrast check is lifted from WinForms.

This was referenced Jul 26, 2024
Closed
Closed
Closed
ericstj
ericstj reviewed Jul 29, 2024
View reviewed changes
@JeremyKuhne
Add alternate system color experimental feature
4800f19 
Allows overriding KnownColor system values with an alternate set, which in the initial iteration is "dark mode" colors. Enables "dark mode" features in Windows Forms.

This is from the approved part of dotnet/winforms#7641 with further naming iteration done offline with API review.
@JeremyKuhne
Respond to feedback
1011768
This was referenced Jul 29, 2024
Open
Open
Closed
ericstj
ericstj approved these changes Jul 29, 2024
View reviewed changes
Copy link
Member

@ericstj ericstj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeremyKuhne JeremyKuhne merged commit 63cb7ec into dotnet:main Jul 29, 2024
@JeremyKuhne JeremyKuhne deleted the alternatesyscolor branch July 29, 2024 20:30
@build-analysis build-analysis bot mentioned this pull request Jul 29, 2024
Closed
@KlausLoeffelmann KlausLoeffelmann mentioned this pull request Aug 4, 2024
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ericstj ericstj ericstj approved these changes

@jeffhandley jeffhandley Awaiting requested review from jeffhandley jeffhandley is a code owner

Assignees

@JeremyKuhne JeremyKuhne

Labels
area-System.Drawing new-api-needs-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JeremyKuhne @ericstj