disable more flaky FileSystemWatcher tests #105637
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @dotnet/area-system-io |
This was referenced Jul 29, 2024
|
I took a more aggressive approach in #105638. Can we close this issue in favor of the other? |
Sure! BTW we need to plan some time to sit down and talk about how we can improve those tests and solve the underlying problem. |
|
[like] David Cantu reacted to your message:
…________________________________
From: Adam Sitnik ***@***.***>
Sent: Monday, July 29, 2024 6:29:53 PM
To: dotnet/runtime ***@***.***>
Cc: David Cantu ***@***.***>; Review requested ***@***.***>
Subject: Re: [dotnet/runtime] disable more flaky FileSystemWatcher tests (PR #105637)
Can we close this issue in favor of the other?
Sure! BTW we need to plan some time to sit down and talk about how we can improve those tests and solve the underlying problem.
—
Reply to this email directly, view it on GitHub<#105637 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AD2MHJBHPESUA2ILCD74RSDZO2C2DAVCNFSM6AAAAABLUYWWR2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJWGYZTAMRRGQ>.
You are receiving this because your review was requested.Message ID: ***@***.***>
|
This was referenced Jul 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #105431 and #103630 (comment) (will need to change labels to "disabled test" once the PR gets merged)