Skip to content

Conversation

sbomer
Copy link
Member

@sbomer sbomer commented Jul 30, 2024

Fixes #102873

Parameter name trimming is currently the only metadata trimming optimization, but I put "all" under this check to include any future metadata trimming optimizations that might impact debuggers.

@dotnet/appmodel PTAL

@ghost ghost added the area-Tools-ILLink .NET linker development as well as trimming analyzers label Jul 30, 2024
@dotnet-policy-service dotnet-policy-service bot added the linkable-framework Issues associated with delivering a linker friendly framework label Jul 30, 2024
Copy link
Member

@MichalStrehovsky MichalStrehovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: did you consider adding a TrimmingTest? (Testing this could probably be approximated with trim-unsafe reflection and we could have variants for both DebuggerSupport=false and the default.)

Removed parameter name is empty, not null, on wasm
Also remove unnecessary WriteLine
@sbomer
Copy link
Member Author

sbomer commented Aug 7, 2024

/ba-g "unrelated timeout in browser-wasm linux Release WasmBuildTests"

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Tools-ILLink .NET linker development as well as trimming analyzers linkable-framework Issues associated with delivering a linker friendly framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parameter name stripping breaks debugger
2 participants