Skip to content

Fix condition to run CertificateCallbackThrowPropagates test on msquic 2.4 and higher #105789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 1, 2024
Merged

Fix condition to run CertificateCallbackThrowPropagates test on msquic 2.4 and higher #105789

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
03027c4
Fix condition
liveans Aug 1, 2024
61527ff
Apply suggestions from code review
liveans Aug 1, 2024
6a164b5
Merge branch 'main' into fix_condition_on_quic_test
liveans Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public class MsQuicTests : QuicTestBase, IClassFixture<CertificateSetup>
{
private static byte[] s_data = "Hello world!"u8.ToArray();
readonly CertificateSetup _certificates;
static bool SupportsAsyncCertValidation => QuicTestCollection.MsQuicVersion >= new Version(2, 4);
static bool DoesNotSupportAsyncCertValidation => QuicTestCollection.MsQuicVersion < new Version(2, 4);

public MsQuicTests(ITestOutputHelper output, CertificateSetup setup) : base(output)
{
Expand Down Expand Up @@ -354,7 +354,7 @@ public async Task UntrustedClientCertificateFails()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/99074", typeof(MsQuicTests), nameof(SupportsAsyncCertValidation))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/99074", typeof(MsQuicTests), nameof(DoesNotSupportAsyncCertValidation))]
public async Task CertificateCallbackThrowPropagates()
{
using CancellationTokenSource cts = new CancellationTokenSource(PassingTestTimeout);
Expand Down