Skip to content

Obsolete ExchangeAlgorithmType, CipherAlgorithmType and HashAlgorithmType and their usage #105875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Oct 3, 2024
Merged

Obsolete ExchangeAlgorithmType, CipherAlgorithmType and HashAlgorithmType and their usage #105875

merged 17 commits into from
Oct 3, 2024

Conversation

rzikm
Copy link
Member

@rzikm rzikm commented Aug 2, 2024 •
edited
Loading

Implements #100361.

This PR obsoletes

  • ExchangeAlgorithmType, CipherAlgorithmType, HashAlgorithmType enums
  • KeyExchangeAlgorithm, KeyExchangeStrength, CipherAlgorithm, CipherAlgorithmStrength, HashAlgorithm, HashStrength properties of SslStream

And leaves TlsCipherSuite SslStream.NegotiatedCipherSuite as the only source of truth.

@ghost
Copy link

ghost commented Aug 2, 2024

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

1 similar comment
@ghost
Copy link

ghost commented Aug 2, 2024

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@rzikm rzikm changed the title 100361-obsolete-ExchangeAlgorithmType-CipherAlgorithmType-HashAlgorithmType Obsolete ExchangeAlgorithmType, CipherAlgorithmType and HashAlgorithmType and their usage Aug 2, 2024
@rzikm rzikm added the breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. label Aug 2, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

dotnet-policy-service bot commented Aug 2, 2024 •
edited by rzikm
Loading

Added needs-breaking-change-doc-created label because this PR has the breaking-change label.

When you commit this breaking change:

  1. Create and link to this PR and the issue a matching issue in the dotnet/docs repo using the breaking change documentation template, then remove this needs-breaking-change-doc-created label.
  2. Ask a committer to mail the .NET Breaking Change Notification DL.

Tagging @dotnet/compat for awareness of the breaking change.

@dotnet-policy-service dotnet-policy-service bot added the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Aug 2, 2024
This was referenced Aug 2, 2024
Closed
Closed
Closed
Closed
@rzikm rzikm marked this pull request as ready for review August 3, 2024 08:46
@rzikm rzikm requested a review from jeffhandley as a code owner August 3, 2024 08:46
@rzikm rzikm requested a review from wfurt August 3, 2024 08:47
@rzikm rzikm mentioned this pull request Aug 3, 2024
Closed
3 tasks
@rzikm rzikm removed the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Aug 3, 2024
@build-analysis build-analysis bot mentioned this pull request Aug 3, 2024
Closed
wfurt added 4 commits August 5, 2024 12:10
@wfurt
9.0
b01d7c1
@wfurt
Suppressions
ef918ac
@wfurt
Merge branch 'main' of https://github.com/dotnet/runtime into 100361-…
d2a75ba 
…obsolete-ExchangeAlgorithmType-CipherAlgorithmType-HashAlgorithmType
@wfurt
Merge branch 'main' of https://github.com/dotnet/runtime into 100361-…
136045b 
…obsolete-ExchangeAlgorithmType-CipherAlgorithmType-HashAlgorithmType
This was referenced Aug 7, 2024
Open
Open
@build-analysis build-analysis bot mentioned this pull request Aug 7, 2024
Open
wfurt
wfurt approved these changes Aug 7, 2024
View reviewed changes
Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wfurt wfurt added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Aug 8, 2024
@wfurt wfurt added this to the 10.0.0 milestone Aug 8, 2024
@rzikm rzikm removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Aug 15, 2024
@rzikm
Copy link
Member Author

rzikm commented Aug 15, 2024

Removing no-merge as this was specifically postponed to 10.0.

@build-analysis build-analysis bot mentioned this pull request Aug 15, 2024
Open
@rzikm
Copy link
Member Author

rzikm commented Aug 27, 2024

Blocked on #106599

@build-analysis build-analysis bot mentioned this pull request Aug 27, 2024
Closed
@rzikm rzikm added the blocked Issue/PR is blocked on something - see comments label Aug 27, 2024
@rzikm rzikm merged commit 49399d9 into dotnet:main Oct 3, 2024
4 checks passed
@teo-tsirpanis teo-tsirpanis removed the blocked Issue/PR is blocked on something - see comments label Oct 3, 2024
@teo-tsirpanis teo-tsirpanis mentioned this pull request Oct 3, 2024
Closed
sirntar pushed a commit to sirntar/runtime that referenced this pull request Oct 3, 2024
@rzikm @wfurt @sirntar
Obsolete ExchangeAlgorithmType, CipherAlgorithmType and HashAlgorithm…
65f82b3 
…Type and their usage (dotnet#105875)

* Obsolete KeyExchangeAlgorithm, KeyExchangeStrength, CipherAlgorithm, CipherAlgorithmStrength, HashAlgorithm and HashStrength properties of SslStream.

* Fix build of S.N.S

* Tentatively unobsolete enum types

* Revert "Tentatively unobsolete enum types"

This reverts commit f5f6435.

* Obsolete other usages of enums

* 9.0

* Suppressions

* Change #ifdef checks to 10.0

* Update compatibility suppressions

* Regenerated suppresions

* Fix build

---------

Co-authored-by: wfurt <[email protected]>
lambdageek pushed a commit to lambdageek/runtime that referenced this pull request Oct 3, 2024
@rzikm @wfurt @lambdageek
Obsolete ExchangeAlgorithmType, CipherAlgorithmType and HashAlgorithm…
70583d4 
…Type and their usage (dotnet#105875)

* Obsolete KeyExchangeAlgorithm, KeyExchangeStrength, CipherAlgorithm, CipherAlgorithmStrength, HashAlgorithm and HashStrength properties of SslStream.

* Fix build of S.N.S

* Tentatively unobsolete enum types

* Revert "Tentatively unobsolete enum types"

This reverts commit f5f6435.

* Obsolete other usages of enums

* 9.0

* Suppressions

* Change #ifdef checks to 10.0

* Update compatibility suppressions

* Regenerated suppresions

* Fix build

---------

Co-authored-by: wfurt <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wfurt wfurt wfurt approved these changes

@jeffhandley jeffhandley Awaiting requested review from jeffhandley jeffhandley is a code owner

Assignees

@rzikm rzikm

Labels
area-System.Net.Security breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. new-api-needs-documentation
Projects
None yet
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@rzikm @wfurt @teo-tsirpanis