Skip to content

Remove unsafe modifier from Memory<T>.Span #106085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 19, 2024
Merged

Remove unsafe modifier from Memory<T>.Span #106085

merged 6 commits into from
Nov 19, 2024

Conversation

xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Aug 7, 2024

No description provided.

@ghost ghost added the area-System.Memory label Aug 7, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Aug 7, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-memory
See info in area-owners.md if you want to be subscribed.

Sergio0694
Sergio0694 reviewed Aug 7, 2024
View reviewed changes
This was referenced Aug 7, 2024
Open
Closed
Open
Open
This was referenced Aug 10, 2024
Open
Closed
Closed
@xtqqczze
Copy link
Contributor Author

@MihuBot

@MihuBot MihuBot mentioned this pull request Oct 22, 2024
Open
This was referenced Oct 22, 2024
Closed
Open
Closed
@build-analysis build-analysis bot mentioned this pull request Oct 22, 2024
Closed
3 tasks
tannergooding
tannergooding reviewed Oct 22, 2024
View reviewed changes
@build-analysis build-analysis bot mentioned this pull request Oct 22, 2024
Open
@build-analysis build-analysis bot mentioned this pull request Nov 17, 2024
Open
3 tasks
@xtqqczze
Copy link
Contributor Author

@stephentoub I can't see how the build analysis failure is related.

@tannergooding tannergooding merged commit 932da77 into dotnet:main Nov 19, 2024
139 checks passed
@xtqqczze xtqqczze deleted the MemoryUnsafeAdd branch November 19, 2024 19:57
mikelle-rogers pushed a commit to mikelle-rogers/runtime that referenced this pull request Dec 10, 2024
@xtqqczze @stephentoub @mikelle-rogers
Remove unsafe modifier from Memory<T>.Span (dotnet#106085)
7c8a3fd 
* Remove `unsafe` modifier from `Memory<T>.Span`

* Make `desiredStartIndex` an `int`

* Use `nuint` and add comment

* fixup!b6b93d972b5b16b345e53c8c07c074cdc85cad9a

---------

Co-authored-by: Stephen Toub <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotas jkotas jkotas left review comments

@tannergooding tannergooding tannergooding left review comments

@GrabYourPitchforks GrabYourPitchforks GrabYourPitchforks approved these changes

@stephentoub stephentoub stephentoub approved these changes

+1 more reviewer

@Sergio0694 Sergio0694 Sergio0694 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
area-System.Memory community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@xtqqczze @GrabYourPitchforks @stephentoub @jkotas @Sergio0694 @tannergooding