Fix threading issue during TraceSource initialization #106192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 9, 2024
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #104457
I used the test from the issue above to verify the fix plus added a loop around
app.InitializeComponent()inMain(). There was no need to show the WPF-based window. This repro'd theInvalidOperationExceptionnearly 100% of the time when running under Visual Studio in the debugger (no breakpoints were necessary). However, I was not able to repro without debug mode and was also not able to repro in console app (in a loop of several hundred runs) or in a new unit test.The fix is to apply the same concurrency semantics as elsewhere in the file when enumerating
TraceListeners.