Simplify MethodDesc::GetLoaderModule #106212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tor` into O(1) operations - Today these are dependent on calling into `ClassLoader::ComputerLoaderModule`, which can be a very complex operation, and always requires walking all of the method's instantiation arguments. - This change makes puts a pointer to the Loader Module onto the `MethodDescChunk` and removes the need for running the potentially complex `ComputeLoaderModule` algorithm.
ghost
added
the
|
Tagging subscribers to this area: @mangod9 |
This was referenced Aug 10, 2024
lambdageek
reviewed
Aug 10, 2024
|
Should we do this for |
|
@lambdageek, yes, we should just add a field on |
|
@lambdageek Although, I'd like to make that change as part of a separate PR, as this one I think is good enough for the |
Sure, sounds good |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turn
MethodDesc::GetLoaderModuleandMethodDesc::GetLoaderAllocatorinto O(1) operationsClassLoader::ComputerLoaderModule, which can be a very complex operation, and always requires walking all of the method's instantiation arguments.MethodDescChunkand removes the need for running the potentially complexComputeLoaderModulealgorithm.