Skip to content

Delete check for old PowerPC Rosetta from CoreCLR PAL #106763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 22, 2024
Merged

Delete check for old PowerPC Rosetta from CoreCLR PAL #106763

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b2dda85
Delete check for old PowerPC Rosetta from CoreCLR PAL
jkotas Aug 21, 2024
5a9a8ef
Fix build break
jkotas Aug 21, 2024
947fc8d
Merge branch 'main' into delete-runningnatively
jkotas Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 0 additions & 26 deletions src/coreclr/pal/src/init/pal.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,21 +127,6 @@ static BOOL INIT_SharedFilesPath(void);
extern void PROCDumpThreadList(void);
#endif

#if defined(__APPLE__)
static bool RunningNatively()
{
int ret = 0;
size_t sz = sizeof(ret);
if (sysctlbyname("sysctl.proc_native", &ret, &sz, nullptr, 0) != 0)
{
// if the sysctl failed, we'll assume this OS does not support
// binary translation - so we must be running natively.
return true;
}
return ret != 0;
}
#endif // __APPLE__

/*++
Function:
PAL_Initialize
Expand Down Expand Up @@ -328,14 +313,6 @@ Initialize(
/*Firstly initiate a lastError */
SetLastError(ERROR_GEN_FAILURE);

#ifdef __APPLE__
if (!RunningNatively())
{
SetLastError(ERROR_BAD_FORMAT);
goto exit;
}
#endif // __APPLE__

CriticalSectionSubSysInitialize();

if(nullptr == init_critsec)
Expand Down Expand Up @@ -740,9 +717,6 @@ Initialize(
ASSERT("returning failure, but last error not set\n");
}

#ifdef __APPLE__
exit :
#endif // __APPLE__
LOGEXIT("PAL_Initialize returns int %d\n", retval);
return retval;
}
Expand Down