Skip to content

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 19, 2024

Backport of #109841 to release/9.0-staging

/cc @stephentoub

Customer Impact

  • Customer reported
  • Found internally

This is an experimental fix related #103984. Some 1p services that use a lot of sync-over-async are experiencing stalls due to some priority inversion issues in work items that get queued to the thread pool. In some situations, the services stall for a long time until a large number of worker threads are injected, which can take a long time. This change would help the app continue to make progress. This change (in addition addition to some app-level throttling to stop new items from being added to the request queue) should help with unblocking.

Regression

  • Yes
  • No

[If yes, specify when the regression was introduced. Provide the PR or commit if known.]

Testing

n/a. This is experimental to validate in production with the config set.

Risk

Low, the feature is behind a config flag

Added for now under the same config flag as is being used for other work prioritization experimentation.
Copy link
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

@stephentoub
Copy link
Member

cc: @mangod9

@jeffschwMSFT jeffschwMSFT added the Servicing-consider Issue for next servicing release review label Nov 20, 2024
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. please get a code review. we will take for consideration in 9.0.x

@jeffschwMSFT jeffschwMSFT added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Nov 21, 2024
@jeffschwMSFT jeffschwMSFT added this to the 9.0.1 milestone Nov 25, 2024
@mangod9 mangod9 merged commit d955059 into release/9.0-staging Nov 26, 2024
146 of 151 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 28, 2024
@jkotas jkotas deleted the backport/pr-109841-to-release/9.0-staging branch December 29, 2024 15:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Threading Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants