Skip to content

Conversation

MichalStrehovsky
Copy link
Member

Reverts #110799

Just for testing. ARM32 native AOT outerloop got broken and it's between this and two RyuJIT changes. I suspect this.

@MichalStrehovsky
Copy link
Member Author

/azp run runtime-nativeaot-outerloop

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

@MichalStrehovsky
Copy link
Member Author

ARM32 still broken here.

@MichalStrehovsky MichalStrehovsky deleted the revert-110799-HijackFrame branch December 20, 2024 08:36
@jkotas
Copy link
Member

jkotas commented Dec 29, 2024

@MichalStrehovsky Have you figured out where the Arm32 regression came from?

I think it was introduced by #110732. There is mismatch in the asm thunk layout that makes us jump to address 0. cc @lateralusX

@jkotas
Copy link
Member

jkotas commented Dec 29, 2024

Submitted #110983 to validate

@MichalStrehovsky
Copy link
Member Author

@MichalStrehovsky Have you figured out where the Arm32 regression came from?

I've been taking public holidays and time off work - investigating weird new ARM32-only issues is not compatible with that :).

Submitted #110983 to validate

I haven't even suspected that one because https://dev.azure.com/dnceng-public/public/_build/results?buildId=899516&view=results already had ARM32 broken and that was presumably before the thunk layout commit. However, your revert of this is the first ARM32 run that is green in two weeks, so I'll just take it as "AzDO works in mysterious ways".

@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants