Skip to content

[release/9.0-staging] Exit the lock before we call into user code and handle losing the race for the RCW table #111162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jan 8, 2025
Merged

[release/9.0-staging] Exit the lock before we call into user code and handle losing the race for the RCW table #111162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
4d2f5b2
Exit the lock before we call into user code and handle losing the rac…
jkoritzinsky Dec 18, 2024
359a854
Better encapsulate logic for the RCW table and the RCW cache.
jkoritzinsky Dec 20, 2024
6315a53
Flip the order of operations to match CoreCLR:
jkoritzinsky Dec 20, 2024
3457a60
Remove outdated comment
jkoritzinsky Dec 20, 2024
a1c33f5
Like CoreCLR, record the NativeObjectWrapper (CoreCLR's ExtObjCxt) in…
jkoritzinsky Dec 20, 2024
1846010
Extract the RCW cache to its own type and do some more cleanup.
jkoritzinsky Dec 20, 2024
ad00609
Pass the NativeObjectWrapper and comProxy as a pair and ensure that t…
jkoritzinsky Dec 20, 2024
56b6923
Reorganize code to reduce indentation
jkoritzinsky Dec 20, 2024
3251a82
A little more refactoring
jkoritzinsky Dec 20, 2024
047f6df
Rename based on our naming conventions.
jkoritzinsky Dec 21, 2024
5b94a6c
Fix UniqueInstance flag
jkoritzinsky Dec 23, 2024
7c3647a
Add a test for the deadlock
jkoritzinsky Dec 23, 2024
718137f
Use manually-managed weak GCHandles to reduce allocations.
jkoritzinsky Dec 23, 2024
53fee70
PR feedback
jkoritzinsky Dec 27, 2024
9536178
Add a cross-apartment test (Windows-only obviously)
jkoritzinsky Jan 6, 2025
a540af1
PR feedback
jkoritzinsky Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading