[cDAC] Implement core stackwalking #111759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
January 6, 2025 10:42
ghost
added
the
max-charlamb
force-pushed
the
cdac-stackwalk
branch
from
4f1fbee to
5d9317a
Compare
This was referenced Jan 24, 2025
Open
max-charlamb
force-pushed
the
cdac-stackwalk
branch
from
8009551 to
a794374
Compare
max-charlamb
commented
Feb 6, 2025
This was referenced Feb 7, 2025
lateralusX
reviewed
Feb 26, 2025
src/native/managed/cdacreader/Microsoft.Diagnostics.DataContractReader.Abstractions/Target.cs
Outdated
Show resolved
Hide resolved
max-charlamb
changed the title
This was referenced Feb 27, 2025
This was referenced Mar 24, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #110758
Implements bulk of the cDAC stackwalking mechanics.
IStackWalkcontractSupports
amd64andarm64architectures. Tested on Windows targetingwin-amd64andlinux-arm64dumps.Supports
InlineCallFramesandSoftwareExceptionFrames.Does not support and will be added in future PRs:
IXCLRDataTask.CreateStackWalk#112366ClrDataAccess::GetFrameName#112274IXCLRDataStackWalk::RequestparametersCLRDATA_REQUEST_REVISIONandCLRDATA_STACK_WALK_REQUEST_SET_FIRST_FRAME[cDAC] ImplementIXCLRDataStackWalk::Requestsupport forCLRDATA_REQUEST_REVISIONandCLRDATA_STACK_WALK_REQUEST_SET_FIRST_FRAME#112275