Skip to content

Conversation

hez2010
Copy link
Contributor

@hez2010 hez2010 commented Jan 25, 2025

In R2R we use a separate helper so we don't need the opts.IsReadyToRun() check. Otherwise the optimization will be blocked under NativeAOT.

Fixes #111822

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jan 25, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jan 25, 2025
@EgorBo
Copy link
Member

EgorBo commented Jan 25, 2025

In R2R we use a separate helper so we don't need the opts.IsReadyToRun() check. Otherwise the optimization will be blocked under NativeAOT.

Fixes #111822

if that code path is still not expected in R2R you should leave that assert there, just add !nativeaot

@hez2010
Copy link
Contributor Author

hez2010 commented Jan 25, 2025

if that code path is still not expected in R2R you should leave that assert there, just add !nativeaot

Done.

@EgorBo
Copy link
Member

EgorBo commented Jan 25, 2025

/azp run runtime-nativeaot-outerloop

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@hez2010
Copy link
Contributor Author

hez2010 commented Jan 25, 2025

Generating native image of System.Private.CoreLib for linux.arm.Checked. Logging to 
  /__w/1/s/artifacts/bin/coreclr/linux.arm.Checked/x64/crossgen2/crossgen2 -o:/__w/1/s/artifacts/bin/coreclr/linux.arm.Checked/System.Private.CoreLib.dll -r:/__w/1/s/artifacts/bin/coreclr/linux.arm.Checked/IL/*.dll --targetarch:arm --targetos:linux -m:/__w/1/s/artifacts/bin/coreclr/linux.arm.Checked/StandardOptimizationData.mibc --embed-pgo-data -O --verify-type-and-field-layout /__w/1/s/artifacts/bin/coreclr/linux.arm.Checked/IL/System.Private.CoreLib.dll --perfmap-format-version:1 --perfmap --perfmap-path:/__w/1/s/artifacts/bin/coreclr/linux.arm.Checked/
  /__w/1/s/src/coreclr/jit/objectalloc.cpp:475
  Assertion failed 'isNativeAot || !comp->opts.IsReadyToRun()'

Is there a case where we don't use CORINFO_HELP_READYTORUN_NEWARR_1 under R2R?

@hez2010
Copy link
Contributor Author

hez2010 commented Jan 25, 2025

It seems that comp->IsTargetAbi(CORINFO_NATIVEAOT_ABI) returns false under NativeAOT. Is this expected?
NVM, I didn't copy the altjit to coreroot.

@hez2010
Copy link
Contributor Author

hez2010 commented Jan 25, 2025

/azp run runtime-nativeaot-outerloop
@EgorBo The assertion should be fixed now. Can you trigger the outerloop nativeaot run again?

Copy link

Commenter does not have sufficient privileges for PR 111827 in repo dotnet/runtime

1 similar comment
Copy link

Commenter does not have sufficient privileges for PR 111827 in repo dotnet/runtime

@EgorBo
Copy link
Member

EgorBo commented Jan 25, 2025

/azp run runtime-nativeaot-outerloop

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@hez2010
Copy link
Contributor Author

hez2010 commented Jan 25, 2025

seems that outerloop is passing now (the failure is unrelated)

@AndyAyersMS
Copy link
Member

NAOT outerloop failure is

[FAIL] System.Net.Http.Functional.Tests.SocketsHttpHandler_HttpClientHandler_MaxResponseHeadersLength_Http3.LargeSingleHeader_ThrowsException(maxResponseHeadersLength: 1)
System.Net.Quic.QuicException : Connection aborted by peer (256).

seems unrelated.

X86 SPMI failures are timeouts; ditto.

@AndyAyersMS AndyAyersMS merged commit 1084c54 into dotnet:main Jan 25, 2025
129 of 134 checks passed
grendello added a commit to grendello/runtime that referenced this pull request Jan 27, 2025
* main: (22 commits)
  Clean up Stopwatch a bit (dotnet#111834)
  JIT: Fix embedded broadcast simd size (dotnet#111638)
  Revert potential UB due to aliasing + more WB removals (dotnet#111733)
  re-enable acceleration of Vector512<long>.op_Multiply (dotnet#111832)
  Handle OSSL 3.4 change to SAN:othername formatting
  JIT: Fix stack allocated arrays for NativeAOT (dotnet#111827)
  JIT: enhance RBO inference for similar compares to constants (dotnet#111766)
  JIT: Don't run optSetBlockWeights when we have PGO data (dotnet#111764)
  [Android] Make sure RuntimeFlavor=CoreCLR when clr subset is specified (dotnet#111821)
  Change empty subject test certificate to include a critical SAN.
  Fix reversed code offsets in GcInfo (dotnet#111792)
  Swap some libraries areas between leads (dotnet#111816)
  Add left-handed spherical and cylindrical billboards (dotnet#109605)
  JIT: revise `optRelopImpliesRelop` to always set `reverseSense` (dotnet#111803)
  Fix Zip64ExtraField handling (dotnet#111802)
  Add build support for Android+CoreCLR (dotnet#110471)
  arm64: Add bic(s) compact encoding (dotnet#111452)
  JIT: Ensure `BBF_PROF_WEIGHT` flag is set when we have PGO data (dotnet#111780)
  Add support for AVX10.2, Add AVX10.2 API surface and template tests (dotnet#111209)
  JIT: Preliminary for enabling inlining late devirted calls (dotnet#111782)
  ...
@github-actions github-actions bot locked and limited conversation to collaborators Feb 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AllocateArrayWithNonGCElements test fails on NativeAOT
3 participants