Skip to content

Use collection expressions in array.cs #113028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Use collection expressions in array.cs #113028

wants to merge 1 commit into from

Conversation

ericstj
Copy link
Member

@ericstj ericstj commented Feb 28, 2025

Trolling copilot

@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Feb 28, 2025
@ericstj ericstj requested a review from Copilot February 28, 2025 23:56
Copilot
Copilot AI reviewed Feb 28, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR refactors array initializations in arrays.cs to use collection expressions instead of explicit array constructors.

  • Replaces instances of "new int [] { ... }" with modern collection expressions.
  • Applies the syntax update in both multidimensional array tests and jagged array initializations.

Reviewed Changes

File Description
src/mono/mono/mini/arrays.cs Updated array initializations to utilize collection expressions.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

This was referenced Mar 1, 2025
Open
Open
Open
@stephentoub
Copy link
Member

Replaces instances of "new int [] { ... }" with modern collection expressions.

Ooooh, did it learn?!

@ericstj
Copy link
Member Author

ericstj commented Mar 3, 2025

We added a repository code rule with @timheuer's help
image

@ericstj ericstj closed this Mar 10, 2025
@ericstj ericstj deleted the ericstj-collection-array-cs-test branch March 10, 2025 18:27
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

Copilot code review Copilot Copilot left review comments

@steveisok steveisok Awaiting requested review from steveisok steveisok will be requested when the pull request is marked ready for review steveisok is a code owner

@vitek-karas vitek-karas Awaiting requested review from vitek-karas vitek-karas will be requested when the pull request is marked ready for review vitek-karas is a code owner

Assignees

@ericstj ericstj

Labels
needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericstj @stephentoub