Disable FEATURE_RX_THUNKS on Windows #113160
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would fix #113114.
Opening as a draft, just want to see what the CI says.
I already know this has problems with CFG.
SetProcessValidCallTargets
works fine first time we call it for the thunks block that is still within the image. But second time we call it when a remapping actually happens, it fails and the thunks are not marked as valid call targets.Cc @filipnavara (I'm including your x86 fix for testing but this could easily be a separate pull request once this is validated - so that you get the credit... and the blame).
Cc @dotnet/ilc-contrib