[wasm] Don't log errors for unsupported cases in PInvokeCollector #113212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
There was a problem hiding this comment.
PR Overview
This PR refines the error logging and exception handling in the PInvokeCollector and related icall signature generation logic to avoid throwing exceptions or logging unactionable errors.
- Changes the icall signature processing to log warnings instead of throwing or erroring out for unsupported cases.
- Updates logging formats and consistency in referencing method names.
- Exposes TryIsMethodGetParametersUnsupported publicly in the PInvokeTableGenerator for external use.
Reviewed Changes
| File | Description |
|---|---|
| src/tasks/WasmAppBuilder/IcallTableGenerator.cs | Renames AddSignature to AddSignatureForMethod and updates logging for unsupported method cases. |
| src/tasks/WasmAppBuilder/PInvokeCollector.cs | Wraps method processing in a try-catch and refines error logging and callback handling. |
| src/tasks/WasmAppBuilder/PInvokeTableGenerator.cs | Changes access of TryIsMethodGetParametersUnsupported to public and updates log messages for consistency. |
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lewing
approved these changes
Mar 6, 2025
|
Looks like some tests need to be fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #112787 was merged we saw the runtime being relinked in the runtime tests which uncovered a couple cases where we were throwing an exception or logging an unactionable error in the PInvokeCollector. Log warnings instead and clean up the code.
Fixes #113025