Skip to content

Some SVE fixes for code generation #113860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 25, 2025
Merged

Some SVE fixes for code generation #113860

merged 5 commits into from
Mar 25, 2025

Conversation

kunalspathak
Copy link
Contributor

While working on agnostic VL, found out some discrepancies in SVE code we are generating.

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 24, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

This was referenced Mar 25, 2025
Closed
Open
@kunalspathak kunalspathak marked this pull request as ready for review March 25, 2025 19:16
@Copilot Copilot AI review requested due to automatic review settings March 25, 2025 19:16
Copilot
Copilot AI reviewed Mar 25, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (2)
  • src/coreclr/jit/emitarm64sve.cpp: Language not supported
  • src/coreclr/jit/hwintrinsiccodegenarm64.cpp: Language not supported

@kunalspathak
Copy link
Contributor Author

@dotnet/arm64-contrib @amanasifkhalid

@build-analysis build-analysis bot mentioned this pull request Mar 25, 2025
Closed
@kunalspathak kunalspathak merged commit d7347b5 into dotnet:main Mar 25, 2025
5 checks passed
@kunalspathak kunalspathak deleted the sve-fixes branch March 25, 2025 21:49
@kunalspathak kunalspathak mentioned this pull request Mar 26, 2025
Closed
@kunalspathak kunalspathak mentioned this pull request Apr 3, 2025
Merged
kunalspathak added a commit that referenced this pull request Apr 4, 2025
@kunalspathak
Fix the encoding for sve_mov (#114244)
14fb8d6 
My #113860 exposed a bug in encoding of sve_mov, where we were wrongly skipping the encoding the Zm field and giving wrong instruction.

Fixes: #113939
@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

Copilot code review Copilot Copilot left review comments

+1 more reviewer

@amanasifkhalid amanasifkhalid amanasifkhalid approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@kunalspathak kunalspathak

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kunalspathak @amanasifkhalid