Skip to content

Conversation

max-charlamb
Copy link
Member

@Copilot Copilot AI review requested due to automatic review settings March 27, 2025 18:58
@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Mar 27, 2025
@max-charlamb max-charlamb requested review from kg, davidwrighton and a team March 27, 2025 18:58
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes redundant modifiers from contract interface method declarations to adhere to modern C# practices.

  • Removed explicit "public virtual" modifiers from interface members in multiple files.
  • Updated method signatures across various contract interfaces for consistency.

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
IStressLog.cs Removed modifiers from interface methods.
IStackWalk.cs Removed redundant modifiers from interface methods.
IRuntimeTypeSystem.cs Removed explicit modifiers from numerous interface methods.
IObject.cs Removed modifiers from interface methods.
ILoader.cs Removed modifiers from interface methods.
IException.cs Removed modifiers from interface methods.
IEcmaMetadata.cs Removed modifiers from interface methods.
IDacStreams.cs Removed modifiers from interface methods.
Comments suppressed due to low confidence (1)

src/native/managed/cdacreader/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IStressLog.cs:40

  • [nitpick] The parameter name 'Logs' is in PascalCase; consider renaming it to 'logs' to follow typical camelCase conventions for parameter names.
IEnumerable<ThreadStressLogData> GetThreadStressLogs(TargetPointer Logs) => throw new NotImplementedException();

@max-charlamb
Copy link
Member Author

/azp run runtime-diagnostics

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@max-charlamb max-charlamb added area-Diagnostics-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Mar 27, 2025
Copy link
Contributor

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

@max-charlamb
Copy link
Member Author

/ba-g #113883

Known tests failures are unrelated

@max-charlamb max-charlamb merged commit baaad1e into dotnet:main Apr 1, 2025
145 of 151 checks passed
thaystg pushed a commit to thaystg/runtime that referenced this pull request Apr 1, 2025
…113983)

* remove superfluous modifiers `public virtual` from contract interfaces
@github-actions github-actions bot locked and limited conversation to collaborators May 2, 2025
@max-charlamb max-charlamb deleted the cdac-unify-contract-interfaces branch June 10, 2025 16:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants