Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/coreclr/inc/clrconfigvalues.h
Original file line number Diff line number Diff line change
Expand Up @@ -720,7 +720,7 @@ RETAIL_CONFIG_DWORD_INFO(EXTERNAL_EnableRiscV64Zbb, W("EnableRiscV64
#endif

// Runtime-async
RETAIL_CONFIG_DWORD_INFO(UNSUPPORTED_RuntimeAsync, W("RuntimeAsync"), 0, "Enables runtime async method support")
RETAIL_CONFIG_DWORD_INFO(UNSUPPORTED_RuntimeAsync, W("RuntimeAsync"), 1, "Enables runtime async method support")

///
/// Uncategorized
Expand Down
2 changes: 1 addition & 1 deletion src/coreclr/nativeaot/Runtime/Crst.h
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
// -----------------------------------------------------------------------------------------------------------
//
// Minimal Crst implementation. Doesn't support much except for the basic locking
// functionality (in particular there is no rank violation checking).
// functionality (in particular there is no rank violation checking)...
//

#ifndef __Crst_h__
Expand Down
2 changes: 1 addition & 1 deletion src/coreclr/vm/array.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
// A 32 dimension array with at least 2 elements in each dimension requires
// 4gb of memory. Limit the maximum number of dimensions to a value that
// requires 4gb of memory.
// If you make this bigger, you need to make MAX_CLASSNAME_LENGTH bigger too.
// If you make this bigger, you need to make MAX_CLASSNAME_LENGTH bigger too..
#define MAX_RANK 32

class MethodTable;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ public class Task : IAsyncResult, IDisposable
[Flags]
internal enum TaskStateFlags
{
// State constants for m_stateFlags;
// State constants for m_stateFlags:
// The bits of m_stateFlags are allocated as follows:
// 0x7FFF0000 - Task state flags
// 0x0000FF00 - internal TaskCreationOptions flags
Expand Down
2 changes: 1 addition & 1 deletion src/tests/async/Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

<PropertyGroup>
<RunAnalyzers>true</RunAnalyzers>
<NoWarn>$(NoWarn);xUnit1013;CS1998</NoWarn>
<NoWarn>$(NoWarn);xUnit1013;CS1998;SYSLIB5007</NoWarn>
<EnableNETAnalyzers>false</EnableNETAnalyzers>
<Features>$(Features);runtime-async=on</Features>
</PropertyGroup>
Expand Down
5 changes: 0 additions & 5 deletions src/tests/async/Directory.Build.targets
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,5 @@
<DisableProjectBuild Condition="'$(RuntimeFlavor)' == 'mono' or '$(TestBuildMode)' == 'nativeaot' or '$(TargetArchitecture)' == 'wasm'">true</DisableProjectBuild>
</PropertyGroup>

<PropertyGroup>
<!-- runtime async testing in main repo NYI -->
<DisableProjectBuild>true</DisableProjectBuild>
</PropertyGroup>

<Import Project="$([MSBuild]::GetPathOfFileAbove(Directory.Build.targets, $(MSBuildThisFileDirectory)..))" />
</Project>
4 changes: 4 additions & 0 deletions src/tests/async/struct/struct.cs
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@ private struct S

public S(int value) => Value = value;

// Roslyn NYI - async in structs. Remove opt-out once supported.
[System.Runtime.CompilerServices.RuntimeAsyncMethodGeneration(false)]
public async Task Test()
{
// TODO: C# compiler is expected to do this, but not in the prototype.
Expand All @@ -59,6 +61,8 @@ public async Task Test()
AssertEqual(102, @this.Value);
}

// Roslyn NYI - async in structs. Remove opt-out once supported.
[System.Runtime.CompilerServices.RuntimeAsyncMethodGeneration(false)]
private async Task InstanceCall()
{
// TODO: C# compiler is expected to do this, but not in the prototype.
Expand Down
Loading