Revert "Alternate approach for HELPER_METHOD_FRAME removal for arithmetic div…" #114308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etic div…" This reverts commit 7aa0868.
ghost
added
the
There was a problem hiding this comment.
Copilot reviewed 17 out of 21 changed files in this pull request and generated no comments.
Files not reviewed (4)
- src/coreclr/classlibnative/float/CMakeLists.txt: Language not supported
- src/coreclr/nativeaot/System.Private.CoreLib/src/System.Private.CoreLib.csproj: Language not supported
- src/coreclr/vm/i386/asmhelpers.asm: Language not supported
- src/libraries/System.Private.CoreLib/src/System.Private.CoreLib.Shared.projitems: Language not supported
|
Tagging subscribers to this area: @mangod9 |
ViktorHofer
approved these changes
Apr 6, 2025
|
/ba-g wasm failures are unrelated |
akoeplinger
deleted the
revert-113286-alternate_approach_to_removingHMF_for_arithmetic
branch
davidwrighton
added a commit
to davidwrighton/runtime
that referenced
this pull request
Apr 7, 2025
…metic div…" (dotnet#114308) This reverts commit 367e0a8.
davidwrighton
added a commit
that referenced
this pull request
Apr 9, 2025
…ide (take2) (#114352) This is a combination of @am11's work in PR #109087 and some work to just rewrite the Windows X86 helpers in assembly. For non 64-bit platforms, remove the helpers For Unix platforms, rely on an implementation which uses an FCall to native code to invoke the various operations. For Windows X86 on CoreCLR, rewrite the helpers in assembly with a tail-call approach for throwing. Also it was noted that the existing helpers do a fair bit of unnecessary stack manipulation, and the manual rewrite avoids all of that. Maybe this will actually be faster. (Turns out it is about the same on performance. The real win would come from re-ordering the argument order, but that's a much more invasive change in the JIT, which I judge to be too risky) Revert #114308 and fix the X86 NativeAOT build
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #113286
It caused an issue on win-x86, see #113286 (comment)