Skip to content

Conversation

mgravell
Copy link
Contributor

@mgravell mgravell commented Apr 9, 2025

implements span/DISH API for HybridCache as proposed in #112866 and agreed at API review, 2025-04-08

Concrete implementation (i.e. an override) will be added over in dotnet/extensions

@Copilot Copilot AI review requested due to automatic review settings April 9, 2025 09:20
@ghost
Copy link

ghost commented Apr 9, 2025

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

1 similar comment
@ghost
Copy link

ghost commented Apr 9, 2025

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • src/libraries/Microsoft.Extensions.Caching.Abstractions/ref/Microsoft.Extensions.Caching.Abstractions.csproj: Language not supported

@mgravell mgravell added the api-approved API was approved in API review, it can be implemented label Apr 9, 2025
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-extensions-caching
See info in area-owners.md if you want to be subscribed.

@mgravell
Copy link
Contributor Author

mgravell commented May 7, 2025

@dotnet/area-extensions-caching any chance of eyeballs?

Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for your contribution @mgravell !

@adamsitnik
Copy link
Member

/ba-g The System.Net.Http.Functional.Test seems to be just a flaky networking test (0.5% failure rate)

@mgravell mgravell merged commit a50dedf into main May 19, 2025
80 of 85 checks passed
@mgravell mgravell deleted the marc/hc-zeroalloc branch May 19, 2025 10:51
@github-actions github-actions bot locked and limited conversation to collaborators Jun 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api-approved API was approved in API review, it can be implemented area-Extensions-Caching new-api-needs-documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants