Skip to content

Use [UN]INSTALL_MANAGED_EXCEPTION_DISPATCHER_EX to backpatch CallDescrWorkerInternal SEH record on x86/funclets #114600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 14, 2025
Merged

Use [UN]INSTALL_MANAGED_EXCEPTION_DISPATCHER_EX to backpatch CallDescrWorkerInternal SEH record on x86/funclets #114600

merged 2 commits into from
Apr 14, 2025

Conversation

filipnavara
Copy link
Member

Ref: #114157 (comment)
Contributes to #113985

@ghost ghost added the area-VM-coreclr label Apr 13, 2025
@filipnavara filipnavara requested a review from jkotas April 13, 2025 16:32
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Apr 13, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

jkoritzinsky
jkoritzinsky reviewed Apr 13, 2025
View reviewed changes
Copy link
Member

@jkoritzinsky jkoritzinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way we can structure this so returning early is safe?

I just removed the "no return" debug logic from this area as the other definitions of these macros are safe to return between.

@filipnavara
Copy link
Member Author

filipnavara commented Apr 13, 2025 •
edited
Loading

Is there a way we can structure this so returning early is safe?

Hmm, I can restructure it as exception handling and move the backpatching to the "rethrow" branch. It's not on a hot path so the additional perf hit is probably negligable.

@filipnavara filipnavara marked this pull request as draft April 13, 2025 18:00
@filipnavara filipnavara marked this pull request as ready for review April 13, 2025 18:46
jkoritzinsky
jkoritzinsky approved these changes Apr 13, 2025
View reviewed changes
Copy link
Member

@jkoritzinsky jkoritzinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you!

@jkoritzinsky jkoritzinsky merged commit 0676e1c into dotnet:main Apr 14, 2025
98 checks passed
@filipnavara filipnavara deleted the seh-backpatch branch April 15, 2025 11:56
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkoritzinsky jkoritzinsky jkoritzinsky approved these changes

@jkotas jkotas Awaiting requested review from jkotas

Assignees
No one assigned
Labels
area-VM-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@filipnavara @jkoritzinsky