Skip to content

[mono][sgen] Fix initialization of can_reduce_color #114637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 15, 2025
Merged

[mono][sgen] Fix initialization of can_reduce_color #114637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
014407a
[mono][sgen] Fix initialization of can_reduce_color
BrzVlad Apr 14, 2025
5e36e41
Disable test on wasm and mobile
BrzVlad Apr 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/mono/mono/metadata/sgen-tarjan-bridge.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -746,7 +746,7 @@ create_scc (ScanData *data)
for (i = dyn_array_ptr_size (&loop_stack) - 1; i >= 0; --i) {
ScanData *other = (ScanData *)dyn_array_ptr_get (&loop_stack, i);
found_bridge |= other->is_bridge;
if (dyn_array_ptr_size (&other->xrefs) > 0) {
if (dyn_array_ptr_size (&other->xrefs) > 0 || found_bridge) {
// This scc will have more xrefs than the ones from the color_merge_array,
// we will need to create a new color to store this information.
can_reduce_color = FALSE;
Expand Down
2 changes: 1 addition & 1 deletion src/tests/GC/Features/Bridge/BridgeTester.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<RequiresProcessIsolation>true</RequiresProcessIsolation>
<DisableProjectBuild Condition="'$(RuntimeFlavor)' != 'Mono'">true</DisableProjectBuild>
<DisableProjectBuild Condition="'$(RuntimeFlavor)' != 'Mono' or '$(TargetArchitecture)' == 'wasm' or '$(TargetsMobile)' == 'true'">true</DisableProjectBuild>
</PropertyGroup>
<ItemGroup>
<Compile Include="BridgeTester.cs" />
Expand Down
Loading