Skip to content

Ensure the trailing slash is removed from the right variable #114795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Ensure the trailing slash is removed from the right variable #114795

wants to merge 1 commit into from

Conversation

tannergooding
Copy link
Member

@tannergooding tannergooding commented Apr 17, 2025 •
edited
Loading

This looks to have been incorrect for a long time (5+ years) and breaks building with CMake 4.0 or later if not resolved.

@Copilot Copilot AI review requested due to automatic review settings April 17, 2025 18:39
Copilot
Copilot AI reviewed Apr 17, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • src/native/corehost/build.cmd: Language not supported

@ghost ghost added the area-Host label Apr 17, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

@filipnavara
Copy link
Member

Duplicate of #114779

@filipnavara filipnavara marked this as a duplicate of #114779 Apr 17, 2025
This was referenced Apr 17, 2025
Open
Open
Open
Closed
Open
Closed
Closed
@github-actions github-actions bot locked and limited conversation to collaborators May 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

@tannergooding tannergooding

Labels
area-Host
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tannergooding @filipnavara