Remove a couple unnecessary 'lock(this)' statements #115013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes unnecessary lock(this) statements in the CategoryName and MachineName property setters to eliminate redundant synchronization that no longer provides additional security checks.
- Removed lock blocks in property setters
- Cleaned up related comments
|
Tagging subscribers to this area: @dotnet/area-system-diagnostics-performancecounter |
jkotas
approved these changes
Apr 24, 2025
This was referenced Apr 24, 2025
ericstj
approved these changes
Apr 29, 2025
|
/ba-g filed an issue for the 1 failure that was not known, but other known failures from this few-day old build have been fixed and are now appearing not known since BA doesn't consider build date / issue close date when evaluating known issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These locks were ported from .NET Framework which did a security check within each lock, but those checks weren't ported over so the lock doesn't do anything special anymore.
Found by CodeQL.