Skip to content

Remove HMF from IL_Throw/IL_ThrowExact/IL_Rethrow #115253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 3, 2025
Merged

Remove HMF from IL_Throw/IL_ThrowExact/IL_Rethrow #115253

merged 4 commits into from
May 3, 2025

Conversation

filipnavara
Copy link
Member

@filipnavara filipnavara commented May 2, 2025 •
edited
Loading

Seems like reusing the SoftwareExceptionFrame from FEATURE_EH_FUNCLETS is quite a minimal change.

Contributes to #95695

@ghost ghost added the area-VM-coreclr label May 2, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label May 2, 2025
@am11
Copy link
Member

am11 commented May 2, 2025

Once #113576 is completed and FEATURE_EH_FUNCLETS is enabled everywhere (incl. x86), would we be able to delete all #ifdef !FEATURE_EH_FUNCLETS branches? If so, would be nice to aim for it for .NET 10 (if possible).

@filipnavara
Copy link
Member Author

filipnavara commented May 2, 2025 •
edited
Loading

would we be able to delete all #ifdef !FEATURE_EH_FUNCLETS branches?

Yes, already have a branch with the cleanups ready...

If so, would be nice to aim for it for .NET 10 (if possible).

I don't think there's much that I can do at the moment. It needs to be validated against the non-public diagnostic/debugger tests.

@filipnavara filipnavara marked this pull request as ready for review May 3, 2025 07:22
@filipnavara
Copy link
Member Author

@jkotas @janvorli Thoughts?

am11
am11 reviewed May 3, 2025
View reviewed changes
@vcsjones vcsjones mentioned this pull request May 3, 2025
Closed
@jkotas
Copy link
Member

jkotas commented May 3, 2025

Is the idea that this may allow us to delete the HMF infrastructure before we get a chance to turn pn FEATURE_EH_FUNCLETS for x86?

@filipnavara
Copy link
Member Author

Is the idea that this may allow us to delete the HMF infrastructure before we get a chance to turn pn FEATURE_EH_FUNCLETS for x86?

Yep.

jkotas
jkotas approved these changes May 3, 2025
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, we can give this a shot

@jkotas jkotas merged commit d57b9d6 into dotnet:main May 3, 2025
93 of 96 checks passed
@filipnavara filipnavara deleted the no-hmf-throw branch May 3, 2025 21:01
@AaronRobinsonMSFT AaronRobinsonMSFT mentioned this pull request May 4, 2025
Closed
25 tasks
@davidwrighton davidwrighton mentioned this pull request May 8, 2025
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Jun 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotas jkotas jkotas approved these changes

+1 more reviewer

@am11 am11 am11 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
area-VM-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@filipnavara @am11 @jkotas