Use secret arg to determine if reverse pinvoke is ILStub or not #117035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified JIT_ReversePInvokeEnterTrackTransitions to use the given secret arg to identify if a method desc needs unwrapping and is a stub. Co-authored-by: Jan Kotas <[email protected]>
hoyosjs
requested review from
Copilot and
jkotas
and removed request for
Copilot
github-actions
bot
added
the
needs-area-label
There was a problem hiding this comment.
Pull Request Overview
This PR updates JIT_ReversePInvokeEnterTrackTransitions to use the provided secret argument to determine if a MethodDesc requires unwrapping when it represents an ILStub.
- Adds an assertion to ensure that secretArg is non-null for ILStub cases.
- Refactors the branch logic to consistently use the UMEntryThunk pointer derived from secretArg.
davidwrighton
approved these changes
Jun 26, 2025
|
/ba-g known wasm build failure |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified JIT_ReversePInvokeEnterTrackTransitions to use the given secret arg to identify if a method desc needs unwrapping and is a stub. This fixes cases where we step through the reverse Pinvoke boundary
Co-authored-by: Jan Kotas [email protected]