Skip to content

De-duplicate PQC type helpers and unify source files. #117089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 27, 2025
Merged

De-duplicate PQC type helpers and unify source files. #117089

merged 2 commits into from
Jun 27, 2025

Conversation

vcsjones
Copy link
Member

  1. Each PQC type had their own identical EncodeAsnWriterToPem. Move it to Helpers and de-dup.
  2. Each PQC type had their own identical (in purpose) "does this ASN.1 blob have trailing data"? Move it to Helpers and de-dup.
  3. PqcBlobHelpers.MLKem does not need to be in its own source file anymore. Merge it with the other one.

@vcsjones vcsjones added this to the 10.0.0 milestone Jun 27, 2025
@vcsjones vcsjones self-assigned this Jun 27, 2025
@Copilot Copilot AI review requested due to automatic review settings June 27, 2025 15:13
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

Copilot
Copilot AI reviewed Jun 27, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@vcsjones vcsjones enabled auto-merge (squash) June 27, 2025 15:51
@vcsjones vcsjones merged commit bdf1d42 into dotnet:main Jun 27, 2025
80 of 87 checks passed
PranavSenthilnathan added a commit to PranavSenthilnathan/runtime that referenced this pull request Jun 27, 2025
@PranavSenthilnathan
Pick up changes from dotnet#117089
1c073c5
This was referenced Jun 27, 2025
Closed
Closed
Closed
Closed
Closed
Open
@vcsjones vcsjones deleted the pqc-dedup branch June 27, 2025 20:15
@github-actions github-actions bot locked and limited conversation to collaborators Jul 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

Copilot code review Copilot Copilot left review comments

@bartonjs bartonjs bartonjs approved these changes

Assignees

@vcsjones vcsjones

Labels
area-System.Security
Projects
None yet
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@vcsjones @bartonjs