Revert "Exit with quick_exit when using debug UCRT (#109006)" #117187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e1d7398.
There was a problem hiding this comment.
Pull Request Overview
This PR reverts the temporary debug UCRT shutdown workaround by removing quick_exit/at_quick_exit usage and associated conditional logic, falling back to the standard atexit and always returning from __managed__Main.
- Drop
at_quick_exitregistration instartup.cpp - Remove
<stdlib.h>include andquick_exitpath in debug bootstrapmain.cpp - Simplify exit behavior to always use
atexitand return the managed main result
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/coreclr/nativeaot/Runtime/startup.cpp | Removed debug-only at_quick_exit(&OnProcessExit) in favor of atexit |
| src/coreclr/nativeaot/Bootstrap/main.cpp | Deleted <stdlib.h> include and debug quick_exit branch; always return __managed__Main |
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
jkotas
reviewed
Jul 1, 2025
Co-authored-by: Jan Kotas <[email protected]>
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jul 2, 2025
jkotas
approved these changes
Jul 2, 2025
|
/ba-g Known issue #117015 that's not getting matched for some reason |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit e1d7398.
The fix didn't work around the problem after all. A CI run from a couple days ago still hits the CRT shutdown bug. Crashdump still at:
We should ideally address this at the xunit single file runner level, but I (or Copilot) cannot find a way to get xunit infrastructure to wait for its background threads to finish.
The problem is that we still have an xunit background thread message bus collector delegator sink proxy factory factory doing some work at the time the main thread is already done. I tried disposing things, and adding more waits, and I'm just giving up, the thread is still there.
We could add a 500 ms wait at the end of single file runner Main and see if that works, I guess.
Cc @dotnet/ilc-contrib