Skip to content

Conversation

MohamedChaawa
Copy link

Fix Infinite loop on OdbcDataReader.internalGetString with UTF-8 text.

When the lengthOrIndicator is 0 the loop should be broken.
This change fixes the issue #86490

Fix Infinite loop on OdbcDataReader.internalGetString with UTF-8 text.

When the lengthOrIndicator is 0 the loop should be broken.
This change fixes the issue dotnet#86490
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jul 1, 2025
@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 1, 2025
@MohamedChaawa MohamedChaawa requested a review from stephentoub July 1, 2025 14:28
@stephentoub
Copy link
Member

Is it possible to add a test for this?

@MohamedChaawa
Copy link
Author

@dotnet-policy-service agree

@MohamedChaawa
Copy link
Author

Is it possible to add a test for this?

@stephentoub OdbcDataReaderTests is added.

@stephentoub
Copy link
Member

Thanks.

I pulled down your change and tried running the test without the fix, and it still passes.

Is this test validating what you expect it to validate?

@stephentoub stephentoub added needs-author-action An issue or pull request that requires more info or actions from the author. area-System.Data area-System.Data.Odbc and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners area-System.Data labels Jul 18, 2025
Copy link
Contributor

Tagging subscribers to this area: @roji, @SamMonoRT
See info in area-owners.md if you want to be subscribed.

Copy link
Contributor

This pull request has been automatically marked no-recent-activity because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will remove no-recent-activity.

Copy link
Contributor

This pull request will now be closed since it had been marked no-recent-activity but received no further activity in the past 14 days. It is still possible to reopen or comment on the pull request, but please note that it will be locked if it remains inactive for another 30 days.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Data.Odbc community-contribution Indicates that the PR has been added by a community member needs-author-action An issue or pull request that requires more info or actions from the author. no-recent-activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants