-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Fix Infinite loop on OdbcDataReader.internalGetString with UTF-8 text #117192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fix Infinite loop on OdbcDataReader.internalGetString with UTF-8 text. When the lengthOrIndicator is 0 the loop should be broken. This change fixes the issue dotnet#86490
src/libraries/System.Data.Odbc/src/System/Data/Odbc/OdbcDataReader.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Data.Odbc/src/System/Data/Odbc/OdbcDataReader.cs
Outdated
Show resolved
Hide resolved
Is it possible to add a test for this? |
@dotnet-policy-service agree |
@stephentoub OdbcDataReaderTests is added. |
Thanks. I pulled down your change and tried running the test without the fix, and it still passes. Is this test validating what you expect it to validate? |
Tagging subscribers to this area: @roji, @SamMonoRT |
This pull request has been automatically marked |
This pull request will now be closed since it had been marked |
Fix Infinite loop on OdbcDataReader.internalGetString with UTF-8 text.
When the lengthOrIndicator is 0 the loop should be broken.
This change fixes the issue #86490