[H/3] Fix large header tests #117412
Merged
[H/3] Fix large header tests #117412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the large-header response tests to avoid using HandleRequestAsync, preventing premature GO_AWAY frames in H/3 tests by manually reading requests and sending responses over a generic connection.
- Replaced
HandleRequestAsyncwithReadRequestDataAsyncandSendResponseAsynccalls in two test cases. - Added explicit disposal of the generic connection in
finallyblocks.
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.MaxResponseHeadersLength.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.MaxResponseHeadersLength.cs
Show resolved
Hide resolved
liveans
reviewed
Jul 8, 2025
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.MaxResponseHeadersLength.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
MihaZupan
approved these changes
Jul 8, 2025
This was referenced Jul 8, 2025
Open
|
/ba-g unrelated or known |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #117015
See #117015 (comment) for explanation.
Replace
HandleRequestAsyncto avoid server sending GO_AWAY and client immediately closing connection after the stream abort. Leading to race of connection_close and stream_abort in H/3 case.