Skip to content

Conversation

gwr
Copy link
Contributor

@gwr gwr commented Jul 9, 2025

Using gcc 13.3 configured as a cross-compiler:

$ /crossrootfs/x64/bin/x86_64-illumos-gcc --version
x86_64-illumos-gcc (GCC) 13.3.0
Copyright (C) 2023 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

And the GNU assembler that uses:

$ /crossrootfs/x64/bin/x86_64-illumos-as --version
GNU assembler (GNU Binutils) 2.42
Copyright (C) 2024 Free Software Foundation, Inc.
This program is free software; you may redistribute it under the terms of
the GNU General Public License version 3 or later.
This program has absolutely no warranty.
This assembler was configured for a target of `x86_64-sun-solaris2.11'.

There are compiler errors in src/coreclr/runtime/amd64/AllocFast.S

 coreclr/runtime/amd64/AllocFast.S: Assembler messages:
  coreclr/runtime/amd64/AllocFast.S:237: Error: missing ')'

@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 9, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jul 9, 2025
@gwr
Copy link
Contributor Author

gwr commented Jul 9, 2025

Apparently some compilers/assemblers don't like a parenthesis expression there.
It might be safer to just use a simple constant and put the math in a comment above.

 on illumos with gcc 13.3 cross copmiler
 coreclr/runtime/amd64/AllocFast.S: Assembler messages:
  coreclr/runtime/amd64/AllocFast.S:237: Error: missing ')'
@gwr gwr marked this pull request as ready for review July 10, 2025 14:51
@jkotas jkotas added area-VM-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jul 13, 2025
@jkotas jkotas merged commit b260561 into dotnet:main Jul 13, 2025
98 of 100 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 13, 2025
@gwr gwr deleted the illumos4g branch September 11, 2025 12:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-VM-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants