[mono][browser] Enable failing tests in smoke tests #117585
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-area-label
This was referenced Jul 14, 2025
lewing
added
area-Codegen-AOT-mono
and removed
needs-area-label
This was referenced Jul 15, 2025
Open
This was referenced Jul 25, 2025
There was a problem hiding this comment.
Pull Request Overview
Enables additional smoke tests for browser targets in the Mono runtime by adding four previously failing test projects to the browser smoke test suite.
- Adds four test projects to browser smoke tests that were previously excluded due to failures
- Expands test coverage for System.Memory, System.Text.RegularExpressions, System.IO.UnmanagedMemoryStream, and System.Diagnostics.StackTrace on browser platform
| <SmokeTestProject Include="$(MSBuildThisFileDirectory)System.Runtime.Intrinsics\tests\System.Runtime.Intrinsics.Tests.csproj" /> | ||
| <SmokeTestProject Include="$(MSBuildThisFileDirectory)System.Memory\tests\System.Memory.Tests.csproj" /> | ||
| <SmokeTestProject Include="$(MSBuildThisFileDirectory)System.Text.RegularExpressions\tests\FunctionalTests\System.Text.RegularExpressions.Tests.csproj" /> | ||
| <SmokeTestProject Include="$(MSBuildThisFileDirectory)System.Runtime/tests/System.IO.UnmanagedMemoryStream.Tests/System.IO.UnmanagedMemoryStream.Tests.csproj" /> |
There was a problem hiding this comment.
[nitpick] This path uses forward slashes inconsistently compared to other entries. Consider using backslashes like the other entries for consistency: System.Runtime\tests\System.IO.UnmanagedMemoryStream.Tests\System.IO.UnmanagedMemoryStream.Tests.csproj
Suggested change
| <SmokeTestProject Include="$(MSBuildThisFileDirectory)System.Runtime/tests/System.IO.UnmanagedMemoryStream.Tests/System.IO.UnmanagedMemoryStream.Tests.csproj" /> | |
| <SmokeTestProject Include="$(MSBuildThisFileDirectory)System.Runtime\tests\System.IO.UnmanagedMemoryStream.Tests\System.IO.UnmanagedMemoryStream.Tests.csproj" /> |
Copilot uses AI. Check for mistakes.
| <SmokeTestProject Include="$(MSBuildThisFileDirectory)System.Memory\tests\System.Memory.Tests.csproj" /> | ||
| <SmokeTestProject Include="$(MSBuildThisFileDirectory)System.Text.RegularExpressions\tests\FunctionalTests\System.Text.RegularExpressions.Tests.csproj" /> | ||
| <SmokeTestProject Include="$(MSBuildThisFileDirectory)System.Runtime/tests/System.IO.UnmanagedMemoryStream.Tests/System.IO.UnmanagedMemoryStream.Tests.csproj" /> | ||
| <SmokeTestProject Include="$(MSBuildThisFileDirectory)System.Diagnostics.StackTrace/tests/System.Diagnostics.StackTrace.Tests.csproj" /> |
There was a problem hiding this comment.
[nitpick] This path uses forward slashes inconsistently compared to other entries. Consider using backslashes like the other entries for consistency: System.Diagnostics.StackTrace\tests\System.Diagnostics.StackTrace.Tests.csproj
Suggested change
| <SmokeTestProject Include="$(MSBuildThisFileDirectory)System.Diagnostics.StackTrace/tests/System.Diagnostics.StackTrace.Tests.csproj" /> | |
| <SmokeTestProject Include="$(MSBuildThisFileDirectory)System.Diagnostics.StackTrace\tests\System.Diagnostics.StackTrace.Tests.csproj" /> |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.