Resolve missing Assert.IsType method in RuntimeBinder tests
#117657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-area-label
dotnet-policy-service
bot
added
the
linkable-framework
There was a problem hiding this comment.
Pull Request Overview
This PR adds an ILLink root descriptor to the Microsoft.CSharp test project to prevent trimming of the Xunit.Assert.IsType method, resolving recent test failures.
- Introduces
ILLink.Descriptors.xmlto preserve the specified assertion method during trimming. - Updates the test project file to include the new descriptor.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/libraries/Microsoft.CSharp/tests/Microsoft.CSharp.Tests.csproj | Adds <TrimmerRootDescriptor> to include the new linker descriptor. |
| src/libraries/Microsoft.CSharp/tests/ILLink.Descriptors.xml | Defines a root descriptor preserving the Xunit.Assert.IsType method. |
Comments suppressed due to low confidence (1)
src/libraries/Microsoft.CSharp/tests/ILLink.Descriptors.xml:1
- [nitpick] Consider adding a comment at the top of ILLink.Descriptors.xml explaining why
Xunit.Assert.IsTypeneeds to be preserved and referencing issue #117565. This will help future maintainers understand the rationale behind this descriptor.
<linker>
lewing
added
area-Microsoft.CSharp
and removed
needs-area-label
|
Tagging subscribers to this area: @cston |
steveisok
approved these changes
Jul 15, 2025
lewing
changed the title
Assert.IsType method in RuntimeBinder tests
|
/ba-g coreclr android timeout is unrelated |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #117565 I have not looked into what caused it to start failing recently.