[Android] Improve InvariantGlobalization support for CoreCLR Android #117748
Conversation
…roperty at MSBuild level
…e at MSBuild level and is no longer used
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
/azp run runtime-android,runtime-androidemulator |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Tagging subscribers to 'arch-android': @vitek-karas, @simonrozsival, @steveisok, @akoeplinger |
|
The tests should be already enabled since my initial PR, where I removed the test project exclusion in |
…for .NET feature switches
…ning them directly
|
/azp run runtime-android,runtime-androidemulator |
|
Azure Pipelines successfully started running 2 pipeline(s). |
There was a problem hiding this comment.
Pull Request Overview
This PR improves InvariantGlobalization support for CoreCLR Android by refactoring how globalization settings are passed to the AndroidAppBuilder. The key change is moving from hardcoded property-based configuration to a more flexible environment variable approach that supports both InvariantGlobalization and the new PredefinedCulturesOnly feature.
- Removes the InvariantGlobalization property from AndroidAppBuilder and replaces it with environment variable configuration
- Adds support for PredefinedCulturesOnly feature through environment variables
- Centralizes Android environment variable configuration in AndroidBuild.props
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/mono/msbuild/android/build/AndroidBuild.props | Adds ItemGroup defining Android environment variables for globalization features |
| src/mono/msbuild/android/build/AndroidBuild.targets | Removes InvariantGlobalization property from AndroidAppBuilderTask |
| src/tasks/AndroidAppBuilder/AndroidAppBuilder.cs | Removes InvariantGlobalization property and assignment from main task class |
| src/tasks/AndroidAppBuilder/ApkBuilder.cs | Removes InvariantGlobalization property and hardcoded environment variable setting |
| src/tests/build.proj | Adds EnvironmentVariables parameter and removes InvariantGlobalization property from AndroidAppBuilderTask |
|
/ba-g Infrasctructure issue and irrelevant platforms. |
4 participants
Description
PredefinedCulturesOnlysupport by passing it as an environment variable at MSBuild level. This feature is intended to work together withInvariantGlobalizationInvariantGlobalizationas an environment variable at MSBuild level, instead of as a property for a cleaner approach.Invariant.Tests.csprojfully pass with none skipped/ignored.Related issues
Invariant.Tests.csprojis failing on CoreCLR Android #117270