Disable data dehydration on Windows by default #117751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves #112927. This improves working set and startup. There's no such impact on non-Windows so keeping it on. Still enabling when optimizing for size.
There was a problem hiding this comment.
Pull Request Overview
This PR updates the native AOT build targets to disable data dehydration (--dehydrate) on Windows by default, while still allowing it when optimizing for size or when explicitly enabled.
- Adds a Windows-specific clause to the
--dehydratecondition inMicrosoft.NETCore.Native.targets - Ensures dehydration remains enabled for
OptimizationPreference=Sizeor whenIlcDehydrate=true
jkotas
approved these changes
Jul 17, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #112927.
This improves working set and startup. There's no such impact on non-Windows so keeping it on. Still enabling when optimizing for size.
Cc @dotnet/ilc-contrib