Remove ExperimentalAttribute from ML-KEM where applicable #117831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes the ExperimentalAttribute from stable ML-KEM components that are part of the FIPS-203 specification, while keeping experimental markers on X.509 and PKCS#8 related functionality that is still in IETF draft status.
Key changes:
- Removed experimental markers from core ML-KEM classes and operations (MLKem, MLKemAlgorithm, MLKemCng, MLKemOpenSsl)
- Removed experimental markers from CNG-related ML-KEM identifiers and blob formats
- Added experimental markers to X.509 SubjectPublicKeyInfo and PKCS#8 PrivateKeyInfo import/export methods
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| MLKemOpenSsl.cs | Removed experimental attribute from MLKemOpenSsl class |
| CngKeyBlobFormat.cs | Removed experimental attributes from ML-KEM blob format properties |
| CngAlgorithmGroup.cs | Removed experimental attribute from MLKem algorithm group property |
| CngAlgorithm.cs | Removed experimental attribute from MLKem algorithm property |
| System.Security.Cryptography.cs | Updated reference assembly with experimental attribute changes |
| MLKemCng.cs | Removed experimental attribute from MLKemCng class |
| MLKemAlgorithm.cs | Removed experimental attribute from MLKemAlgorithm class |
| MLKem.cs | Removed experimental attribute from MLKem class and added experimental markers to X.509/PKCS#8 methods |
|
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones |
bartonjs
approved these changes
Jul 18, 2025
This was referenced Jul 20, 2025
Open
This was referenced Jul 22, 2025
|
/ba-g known timeouts and wasm test failures |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ML-KEM has enough stability to it now where we can start to remove the
Experimentalattribute.Specifically, things that are part of the FIPS-203 specification can be unmarked. Things that are still not finalized, such as a IETF work (X.509, SubjectPublicKeyInfo, and PrivateKeyInfo) will remain marked as experimental because the drafts may introduce breaking changes.