Skip to content

Conversation

MichalStrehovsky
Copy link
Member

This could be used for #117712 and is a useful piece of metadata.

I was going back and forth between placing this here or somewhere in the dotnet/sdk repo but since this is related to the analyzer, it feels okay here too.

This could be used for #117712 and is a useful piece of metadata.

I was going back and forth between placing this here or somewhere in the dotnet/sdk repo but since this is related to the analyzer, it feels okay here too.
@Copilot Copilot AI review requested due to automatic review settings July 24, 2025 05:45
@MichalStrehovsky MichalStrehovsky requested a review from sbomer as a code owner July 24, 2025 05:45
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds automatic emission of the IsAotCompatible assembly attribute metadata for assemblies that are marked as AOT-compatible. This provides runtime metadata that can be used to identify AOT-compatible assemblies, supporting issue #117712.

Key Changes

  • Adds conditional assembly attribute generation for IsAotCompatible metadata when the MSBuild property $(IsAotCompatible) is set to true
  • Follows the same pattern as the existing IsTrimmable attribute emission

@github-actions github-actions bot added the area-Tools-ILLink .NET linker development as well as trimming analyzers label Jul 24, 2025
@dotnet-policy-service dotnet-policy-service bot added the linkable-framework Issues associated with delivering a linker friendly framework label Jul 24, 2025
Copy link
Contributor

Tagging subscribers to this area: @dotnet/illink
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@sbomer sbomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@MichalStrehovsky
Copy link
Member Author

/ba-g too many WASM failures to count

@MichalStrehovsky MichalStrehovsky merged commit 9da102b into main Jul 24, 2025
74 of 80 checks passed
@MichalStrehovsky MichalStrehovsky deleted the MichalStrehovsky-patch-1 branch July 24, 2025 20:44
@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Tools-ILLink .NET linker development as well as trimming analyzers linkable-framework Issues associated with delivering a linker friendly framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants