Fix SearchValues asserts for WASM #118030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes SearchValues assertions that were failing on WebAssembly (WASM) by updating the Debug.Assert conditions to properly account for WASM's PackedSimd support alongside ARM's AdvSimd support.
- Updates comments to mention WASM alongside ARM for non-ASCII value usage
- Modifies assertion logic to check for both AdvSimd.IsSupported and PackedSimd.IsSupported
- Adds an additional assertion in AsciiCharSearchValues to validate character range constraints
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| AsciiCharSearchValues.cs | Updates assertion and comment to include WASM PackedSimd support, adds range validation |
| AsciiByteSearchValues.cs | Updates assertion and comment to include WASM PackedSimd support |
|
Tagging subscribers to this area: @dotnet/area-system-memory |
stephentoub
approved these changes
Jul 24, 2025
lewing
approved these changes
Jul 24, 2025
This was referenced Jul 24, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #118022