Skip to content

[API Proposal]: Implement IParsable<TSelf> et cetera on IPEndPoint #118095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 2, 2025
Merged

[API Proposal]: Implement IParsable<TSelf> et cetera on IPEndPoint #118095

merged 6 commits into from
Sep 2, 2025

Conversation

pedrobsaila
Copy link
Contributor

Fixes #114405

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jul 27, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

@build-analysis build-analysis bot mentioned this pull request Jul 27, 2025
Open
@ManickaP
Copy link
Member

Hey @pedrobsaila, we are past feature complete for 10.0. So this PR cannot be merged until we branch out and main becomes .NET 11. Please do continue work on the PR, I'll find someone to be responsible for the review. Just letting you know about the state of things right now.

@ManickaP ManickaP self-assigned this Aug 5, 2025
ManickaP
ManickaP reviewed Aug 6, 2025
View reviewed changes
@build-analysis build-analysis bot mentioned this pull request Aug 8, 2025
Open
ManickaP
ManickaP approved these changes Aug 25, 2025
View reviewed changes
Copy link
Member

@ManickaP ManickaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for being patient. This looks good, ready to merge. I left only a small comment about test, nothing serious.

Thank you!

ManickaP
ManickaP reviewed Sep 2, 2025
View reviewed changes
Copy link
Member

@ManickaP ManickaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ManickaP ManickaP merged commit 09e6ddd into dotnet:main Sep 2, 2025
88 checks passed
@pedrobsaila pedrobsaila deleted the 114405 branch September 2, 2025 11:59
@pentp
Copy link
Contributor

pentp commented Sep 2, 2025

Is it too late to get this into .NET 10? 🙃

@tannergooding
Copy link
Member

Is it too late to get this into .NET 10? 🙃

CC. @jeffhandley.

My expectation is yes it is too late. We snapped RC1 already and so this would end up going very hot into RC2, well past the normal cutoff. It isn't as low risk as other changes and was already coming in late, after the cutoff, back in July.

@ManickaP
Copy link
Member

ManickaP commented Sep 3, 2025

Is it too late to get this into .NET 10? 🙃

Yes, it was intentionally held back as the PR went up after feature complete, see #118095 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManickaP ManickaP ManickaP approved these changes

@MihaZupan MihaZupan MihaZupan left review comments

Assignees

@ManickaP ManickaP

Labels
area-System.Net community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[API Proposal]: Implement IParsable<TSelf> et cetera on IPEndPoint
5 participants
@pedrobsaila @ManickaP @pentp @tannergooding @MihaZupan